Skip to content

Clarify Session Management Persistence Documentation#18345

Merged
jzheaux merged 3 commits into
spring-projects:6.5.xfrom
sankranty:session-docs-correction
Mar 20, 2026
Merged

Clarify Session Management Persistence Documentation#18345
jzheaux merged 3 commits into
spring-projects:6.5.xfrom
sankranty:session-docs-correction

Conversation

@sankranty

Copy link
Copy Markdown
Contributor

Corrected that starting from Spring Security 6 security context is not automatically saved by default.

@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged label Dec 20, 2025
Comment thread docs/modules/ROOT/pages/servlet/authentication/session-management.adoc Outdated

@jzheaux jzheaux left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, @sankranty, thanks for the PR. I agree that this could be clearer. I've left my suggestions inline.

Comment thread docs/modules/ROOT/pages/servlet/authentication/session-management.adoc Outdated
@jzheaux jzheaux self-assigned this Jan 14, 2026
@jzheaux jzheaux added in: docs An issue in Documentation or samples type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged labels Jan 14, 2026
@jzheaux jzheaux added this to the 6.4.14 milestone Jan 14, 2026
@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Jan 14, 2026
@rwinch rwinch removed this from the 6.4.14 milestone Feb 10, 2026
@jzheaux jzheaux removed the status: waiting-for-feedback We need additional information before we can continue label Feb 10, 2026
@jzheaux jzheaux added the status: waiting-for-feedback We need additional information before we can continue label Feb 18, 2026
@jzheaux jzheaux force-pushed the session-docs-correction branch from c836ffb to f18004e Compare March 3, 2026 23:20
@jzheaux jzheaux changed the title Fix defaults description in Session Management doc Clarify Session Management Persistence Documentation Mar 3, 2026
@jzheaux jzheaux changed the base branch from main to 6.5.x March 3, 2026 23:20
@jzheaux

jzheaux commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

@sankranty, I polished some of the wording to clarify how sessions are persisted in modern Spring Security versions.

In order to merge your contribution, your DCO signature needs to be corrected. Please note how the email address in your commit header is different from the email address in your DCO signature. Can you take a look at that please and update that commit?

@sankranty sankranty force-pushed the session-docs-correction branch 3 times, most recently from dcf156e to 03a48ac Compare March 9, 2026 09:19
sankranty and others added 2 commits March 9, 2026 12:22
Corrected that starting from Spring Security 6
security context is not automatically saved by default.

Signed-off-by: sankranti <sankranty@gmail.com>
Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
@sankranty sankranty force-pushed the session-docs-correction branch from 03a48ac to 8dab68a Compare March 9, 2026 09:23
@sankranty

Copy link
Copy Markdown
Contributor Author

@jzheaux Thank you for adding detailed clarification. I updated sign-off, now it's correct.

@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Mar 9, 2026
@sankranty

Copy link
Copy Markdown
Contributor Author

Also I noticed that commit ea3b112 was added to this branch, what I guess was by accident, so I removed it.

Signed-off-by: Rob Winch <362503+rwinch@users.noreply.github.com>
@jzheaux jzheaux added this to the 6.5.10 milestone Mar 20, 2026
@jzheaux jzheaux merged commit 9fed1ac into spring-projects:6.5.x Mar 20, 2026
11 checks passed
@jzheaux

jzheaux commented Mar 20, 2026

Copy link
Copy Markdown
Collaborator

Thanks, @sankranty! This is now merged into 6.5.x, 7.0.x, and main.

@jzheaux jzheaux removed the status: feedback-provided Feedback has been provided label Mar 20, 2026
@sankranty sankranty deleted the session-docs-correction branch March 22, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in: docs An issue in Documentation or samples type: enhancement A general enhancement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants